Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass encoding as a positional argument #3201

Conversation

stevecheckoway
Copy link
Contributor

What problem is this PR intended to solve?

The encoding keyword is ignored. An encoding argument should be passed
as a positional argument instead.

Have you included adequate test coverage?

This is fixing the tests, but it does raise the question what, precisely, the
tests were testing before.

Does this change affect the behavior of either the C or the Java implementations?

No behavioral changes.

The `encoding` keyword is ignored. An encoding argument should be passed
as a positional argument instead.
@flavorjones
Copy link
Member

Superseded by #3204 which includes these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants