Simplify upstream latency collector and measure gateway latency #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafax
reviewed
May 16, 2024
| headers.set('Authorization', `Bearer ${this.fastPathAccessToken}`) | ||
| addTraceparent(headers) | ||
| addCustomUserAgent(headers) | ||
| const uri = 'https://cody-gateway.sourcegraph.com/healthz' |
There was a problem hiding this comment.
The right URL seems to be https://cody-gateway.sourcegraph.com/-/healthz (your URL 404s for me)?
There was a problem hiding this comment.
Hm this one also does not seem right. I wasn't able to find an endpoint that works so decided that a 404 endpoint from the same endpoint should still have the same round trip time.
rafax
reviewed
May 16, 2024
rafax
approved these changes
May 16, 2024
|
Had one thought yesterday while I couldn't sleep at 3am (🙃):
|
philipp-spiess
deleted the
ps/simplify-upstream-health-and-measure-gateway-latency
branch
rafax
pushed a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes CODY-1605
This PR changes the way we track upstream latency (= RTT to the Sourcegraph instance). Instead of measuring every 10 minutes and then exporting the median to the completion metadata, I thought that it might be simpler to include the last measurement with the completion data (and then we can run an aggregation on that). While coding, completion suggestions should happen more frequent then every 10 minutes so this will give us a higher resolution while we avoid to maintain a list.
Additionally, I've added a second parameter to measure the latency to Gateway. This is only turned on for Free/Pro users right now (to avoid outgoing traffic in air-gapped instances).
Furthermore I added tracing to the upstream pings. With our current rate limit, one two two traces every ~10 minutes should be fine (again I assume this happen far less frequently than completion suggestions) but we can revisit this later.
The benefit of exporting this as a trace is that we can later forward the trace to the SG instance and convert it to a metric.
Test plan