Report more "unexpected bare value" errors #7887
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While helping a user attempt to write some code today, I noticed that they had
this in their code and it did the right thing statically but only worked at
runtime because generics are erased (
T::Array[x]
). Had they attempted to dosomething similar with
T.class_of
orT.any
or something else, it would nothave done the thing they hoped it would have.
Ideally an even better error message would include something like an autocorrect
like "Did you meant to explicitly annotate this value's type here?" and offer to
replace
x
in the test withT.type_parameter(:U)
, or whatever the type ofx
is. That isn't always going to be the right suggestion, but it will at least get
the user closer to understanding what the problem is.
Test plan
See included automated tests.