Teach guessOverload to respect block arity #7859
Conversation
Sometimes it's useful to be able to use the arity of the block to guess an overload. This isn't perfect for all the reasons that overload checking isn't perfect, but there are some places where this is useful, especially in abstractions that check the proc's arity when deciding how to call the block. This is also a pre-requisite for doing something like #7741, which is a partial fix for #3914 / #4149, where we infer the types of `Kernel#lambda` blocks by codegenerating overloaded signatures.
|
We have a policy of testing changes to Sorbet against Stripe's codebase before Stripe employees can see the build results here: → https://go/builds/bui_PzYwe4JrCo8jCG |
|
We have a policy of testing changes to Sorbet against Stripe's codebase before Stripe employees can see the build results here: → https://go/builds/bui_PzcarmQnhPi08z |
Motivation
Fixes #7743
Sometimes it's useful to be able to use the arity of the block to guess an
overload.
This isn't perfect for all the reasons that overload checking isn't
perfect, but there are some places where this is useful, especially in
abstractions that check the proc's arity when deciding how to call the
block.
This is also a pre-requisite for doing something like #7741, which is a
partial fix for #3914 / #4149, where we infer the types of
Kernel#lambdablocks by codegenerating overloaded signatures.Test plan
See included automated tests, which show the master behavior and how it changes.