Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] treat calls to abstract methods in static same as runtime #7853

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

neilparikh
Copy link
Collaborator

Motivation

Test plan

See included automated tests.

@neilparikh
Copy link
Collaborator Author

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

https://go/builds/bui_PyonPSf2YqKNS1
https://go/builds/bui_PyonCCYkpQfq8Q
https://go/builds/bui_PyonClZBQrUBm8

Comment on lines +708 to +716
auto possiblities = symbol.data(gs)->findParentMethodTransitiveAll(gs, targetName);
for (auto overload : possiblities) {
if (!overload.data(gs)->flags.isAbstract) {
mayBeOverloaded = overload;
break;
}
}
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto possiblities = symbol.data(gs)->findParentMethodTransitiveAll(gs, targetName);
for (auto overload : possiblities) {
if (!overload.data(gs)->flags.isAbstract) {
mayBeOverloaded = overload;
break;
}
}
}
auto possibilities = symbol.data(gs)->findParentMethodTransitiveAll(gs, targetName);
for (auto overload : possibilities) {
if (!overload.data(gs)->flags.isAbstract) {
mayBeOverloaded = overload;
break;
}
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants