Flush errors after namer and resolver #7796
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR flushes errors after running the namer and the resolver.
The change also adds cache for the errors, preventing Sorbet from losing errors due to additional flushes
Motivation
This would make Sorbet feel more responsive, as errors would be displayed more quickly in LSP mode.
I tested the PR on Stripe's codebase by inserting a specific piece of code and tracking the timing of error reports through LSP logs
Test plan
See included automated tests.