Restore Ruby 3.4 compatibility in T::Props::Serializable #7779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froydnj
requested changes
Mar 22, 2024
Followup: sorbet#7778 Followup: sorbet#7710 Exceptions are not guaranteed to have a `#backtrace_locations` because of `Exception#set_backtrace` and `Kernel#raise(error, message, backtrace)`. It's still prefereable to use `#backtrace_location` when present as it requires much less string parsing. But if it's missing we can fallback to parse backtraces the old way, however we need to account for Ruby 3.4 newer format.
casperisfine
force-pushed
the
ruby-3.4-backtraces-2
branch
from
d0b6b4b
to
f7da100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup: #7778
Followup: #7710
Exceptions are not guaranteed to have a
#backtrace_locationsbecause ofException#set_backtraceandKernel#raise(error, message, backtrace).It's still prefereable to use
#backtrace_locationwhen present as it requires much less string parsing.But if it's missing we can fallback to parse backtraces the old way, however we need to account for Ruby 3.4 newer format.
@froydnj @jez @paracycle