Make sure to use config.cwd as the cwd of the language server
#7767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the `cwd` of the language server was never being set correctly, and it would always default to `workspace.rootPath`. This makes any setup that uses `config.cwd` to not be respected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the
cwdof the language server was never being set correctly, and it would always default toworkspace.rootPath. This makes any setup that usesconfig.cwdto not be respected.Motivation
Fix what I assume is a bug, but @froydnj's comment here might mean this is intentional.
Test plan
See included automated tests.