Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize prop_set by eschewing instance_exec #7683

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

froydnj
Copy link
Contributor

@froydnj froydnj commented Feb 9, 2024

Motivation

Turns out this way is ~10% faster (!).

Test plan

See included automated tests.

@froydnj
Copy link
Contributor Author

froydnj commented Feb 9, 2024

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

https://go/builds/bui_PX5EKuGIyI6ltR
https://go/builds/bui_PX5EIsm0YBh4WJ
https://go/builds/bui_PX5FXM4wLaF79c

This change also has sorbet-runtime changes. Those tests:

https://go/builds/bui_PX5OLYOrnziELw

@jez
Copy link
Collaborator

jez commented Feb 9, 2024

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

https://go/builds/bui_PX5JGW99mvkX3m
https://go/builds/bui_PX5Jh9I9TWDP5k
https://go/builds/bui_PX5JfPwwawhUDj

This change also has sorbet-runtime changes. Those tests:

https://go/builds/bui_PX5PMYr1nsy0s8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants