Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appdata related changes #110

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Appdata related changes #110

merged 7 commits into from
Jul 10, 2024

Conversation

yakushabb
Copy link
Contributor

Please review individually.

I implemented some of my old PRs to improve appdata related paper cuts.

yakushabb and others added 7 commits April 6, 2024 17:57
It appears that the appstream project no longer supports
`translatable=no` properties, and gettext extract them as translatable.

I opened an issue to inform about the situation, but `translatable=no`
properties are not accepted by developers. You can find the issue
here: `https://github.com/ximion/appstream/issues/623`

**Please test your script or string extraction process before merging this PR.**

> In MetaInfo files, each individual paragraph of a description
> (or enumerated entry) is translated individually, however,
> you can only exclude the complete block from being translated
> by adding `translate="no"` to the description element.

Source: https://freedesktop.org/software/appstream/docs/sect-Quickstart-Translation.html
Flathub requires a developer tag and developer ID. Also Appstream decided to use rdns structure for developer ID.

It allows reverse-dns IDs like sh.cozy, de.geigi or Fediverse handle (like @user@example.org)

> A developer tag with a name child tag must be present.
> Only one developer tag is allowed and the name tag also must be present only once in untranslated form.

```
<developer id="tld.vendor">
  <name>Developer name</name>
</developer>
```
Source: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#name-summary-and-developer-name

> The element should have a id property, containing a unique ID to identify the component developer / development team. It is recommended to use a reverse-DNS name, like org.gnome or io.github.ximion, or a Fediverse handle (like @user@example.org) as ID to achieve a higher chance of uniqueness.

Source: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer
Keep only files that contain translatable strings.
Flathub now use appstremcli to validate appdata

More information: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#validation
> Place the MetaInfo file into /app/share/metainfo/,
> name it %{id}.metainfo.xml, where %{id} is the ID.
> This ID and the filename must match exactly with the id set in the Flatpak manifest.

Source: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#path-and-filename
@sonnyp sonnyp merged commit 6210766 into sonnyp:main Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants