Merge pull request #26 from alessandromrc/main-1x

Performance Improvement when writing
sombriks · Mar 29, 2024 · 5787dd0 · 5787dd0
2 parents e9e8304 + 6907306
commit 5787dd0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/binding.gyp b/binding.gyp
@@ -16,6 +16,12 @@
  "libraries" : [
  "-lgpiod"
  ],
+ "cflags": [
+ "-O3"
+ ],
+ "lflags": [
+ "-flto"
+ ]
  }]
  ]
  }

diff --git a/src/line.cc b/src/line.cc
@@ -110,14 +110,12 @@ NAN_METHOD(Line::getValue) {
 }
 
 NAN_METHOD(Line::setValue) {
- Line *obj = Nan::ObjectWrap::Unwrap<Line>(info.This());
- if (!obj->line) {
- Nan::ThrowError("::setValue() for line==NULL");
- return;
+ Line *obj = ObjectWrap::Unwrap<Line>(info.Holder());
+ v8::Local<v8::Context> context = Nan::GetCurrentContext();
+ uint32_t value = info[0]->Uint32Value(context).FromJust();
+ if (gpiod_line_set_value(obj->line, value) == -1) {
+ return Nan::ThrowError("setValue() failed.");
  }
- unsigned int value = Nan::To<unsigned int>(info[0]).FromJust();
- if (-1 == gpiod_line_set_value(obj->getNativeLine(), value))
- Nan::ThrowError("::setValue() failed");
 }
 
 NAN_METHOD(Line::requestInputMode) {