Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme WebID_TLS Section #221

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

perploug
Copy link

  • Remove reference to databox as it is being retired
  • Moved the Firefox compatibility up front
  • Changed wording and sentences so it flows more natural with the above changes

- Remove reference to databox as it is being retired
- Moved the Firefox compatibility up front
- Changed wording and sentences so it flows more natural with the above changes
@RubenVerborgh
Copy link
Contributor

@perploug Is that you? 😮 (Umbraco, 10 years ago?)

@perploug
Copy link
Author

perploug commented Oct 30, 2018

@RubenVerborgh Haha yeah it is :) Still remember the umbraco retreat and your work on the datalayer, good times!

@melvincarvalho
Copy link
Member

databox should not be retired, just not accepting new registrations

It is in use

@kjetilk
Copy link
Member

kjetilk commented Oct 30, 2018

databox should not be retired, just not accepting new registrations

It is in use

Yeah, but since this is a section titled "Get a WebID", it would be reasonable to accept the patch, wouldn't it?

@kjetilk kjetilk added the triage Issues that need team review label Oct 30, 2018
@RubenVerborgh RubenVerborgh self-assigned this Oct 30, 2018
@perploug
Copy link
Author

Retired or not retired, just make up your mind :) - since https://databox.me/ states the exact phrase "Databox.me is being retired" - that is what I assume is the case.

README.md Outdated
@@ -183,10 +183,9 @@ identity provider, such as (2018/2) [solid.community](https://solid.community/),

#### WebID_TLS

A WebID profile from one of the Solid-compliant [identity providers](https://solid.github.io/solid-idps/), such as [databox.me](https://databox.me/),
WebID-TLS currently only works in Firefox at the moment (Oct 2018)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perploug Yeah I noticed that Chrome didn't give me the popup anymore lately. Would that still be possible behind a flag?

@melvincarvalho @timbl @kidehen You are client certificate users, what browser(s) work(s) for you?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RubenVerborgh ,

There are no browser specific issues that impede my use of WebID-TLS. It just works :)

/cc @melvincarvalho @timbl

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perploug But it didn't work for you in other browsers?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use TLS certs to log in to with chrome, and this still works for me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use WebID-TLS on chrome and firefox. No issues here either.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use the WebId-TLS option as there is it apparently not supported on the solid.community pods (I seem to recall a comment that this option was being deprecated)

The reason the firefox comment is in there is because it was there before, I just moved to the beginning of the sentence - but based on your comments it seems it can be removed all together - will update the PR

And to confirm I do get prompted for a certificates on Osx Chrome and firefox.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebID-TLS has always been the primary login system for solid. It is not deprecated. The plan is to support it on solid.community in future. But code needs to be there first.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melvincarvalho okey - that clears things up a bit - is there any provider which supports WebID-TLS? otherwise I think that should be part of the documentation that users cannot currently expect this functionality

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

databox is the provider that supports WebID-TLS, but it doesnt yet support WebID-OIDC

There is in theory a way where you wrap WebID-TLS inside WebID-OIDC, which also works today, or should work today.

However, by nature the TLS is more secure because it involves two parties, and OIDC is less secure because it requires a trusted third party. On the other hand, the trusted third party has a good network effect today, due to the nature of large email and identity providers.

Over time, it would be good for both protocols to be supported. That was the design aim, but we are not there yet.

@RubenVerborgh RubenVerborgh added this to In progress in Node Solid Server via automation Oct 30, 2018
@RubenVerborgh RubenVerborgh added documentation and removed triage Issues that need team review labels Oct 30, 2018
@kjetilk
Copy link
Member

kjetilk commented Oct 30, 2018

* @melvincarvalho Can we use a better word instead of "retired" at https://databox.me/?

Perhaps it should say "databox.me is now not accepting new users, please use..."?

@melvincarvalho
Copy link
Member

Sounds good! Hopefully if gold gets some more development, ie to include the popup in the databrowser, we can switch on users again.

It seems all browsers now support tls, so removing this
@kjetilk kjetilk removed this from In progress in Node Solid Server Nov 6, 2018
@justinwb justinwb added the priority-high to be used for important issues and pull requests that need to be addressed soon label Nov 6, 2018
@kjetilk
Copy link
Member

kjetilk commented Apr 1, 2019

What's the status here?

Base automatically changed from master to main February 24, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation priority-high to be used for important issues and pull requests that need to be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants