Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the _padding value to 8.0; This is because the default 24.0 value… #81

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

SamuelWakoli
Copy link

… was taking a huge space.

I also created a new parameter, "padding" of type: EdgeInsetsGeometry? If this padding is null, we then use the new default 8.0 for all sides.

… was taking a huge space.

I also created a new parameter, "padding" of type: EdgeInsetsGeometry?
If this padding is null, we then use the new default 8.0 for all sides.
@illia-romanenko
Copy link
Contributor

Hi @SamuelWakoli, thanks for your PR. Could you please fix lints/github actions?

I commented custom lints, I'm personally unaware why we need it for now.
@SamuelWakoli
Copy link
Author

SamuelWakoli commented Jun 6, 2024

Hello @illia-romanenko I have commented the following Github Action check:
#- name: Custom lint
# run: dart run custom_lint

We get this warning, that prevents my PR from passing, although the warning is not related with the PR;
There is an unused parameter in the following file:
lib/src/utils/mistake_popup.dart:39:22

I have a feeling that the parameter has a purpose in future;
Thank you

@illia-romanenko
Copy link
Contributor

I feel like we better remove that parameter then and return lints.

@SamuelWakoli
Copy link
Author

Alright sir;

Replaced unused parameter with an underscore in the following GitHub Action check warning:

There is an unused parameter in the following file:
lib/src/utils/mistake_popup.dart:39:22
@illia-romanenko illia-romanenko self-requested a review June 7, 2024 14:52
@illia-romanenko
Copy link
Contributor

What do you think if we change default back to 24? As while changing to 8 might be reasonable, it will introduce breaking change to existing users, probably it doesn't make sense to release it as a breaking change?

@SamuelWakoli
Copy link
Author

Alright sir;
That's a great consideration. I'm updating it now.

@SamuelWakoli
Copy link
Author

Let's consider existing users. then the new parameter will allow new users to update the padding themselves. It totally makes sense sir;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants