Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dispose to the LanguageCheckService #34

Merged
merged 2 commits into from
May 25, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/core/controllers/colored_text_editing_controller.dart
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,12 @@ class ColoredTextEditingController extends TextEditingController {
);
}

@override
void dispose() {
languageCheckService.dispose();
super.dispose();
}

/// Replaces mistake with given replacement
void replaceMistake(Mistake mistake, String replacement) {
text = text.replaceRange(mistake.offset, mistake.endOffset, replacement);
Expand Down
6 changes: 6 additions & 0 deletions lib/domain/language_check_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,10 @@ abstract class LanguageCheckService {

/// Returns found mistakes in the given [text].
Future<List<Mistake>> findMistakes(String text);

/// Disposes resources of this [LanguageCheckService].
Future<void> dispose() async {
// does nothing by default, but implementations may need to use it
return;
}
mitryp marked this conversation as resolved.
Show resolved Hide resolved
}
7 changes: 7 additions & 0 deletions lib/implementations/debounce_lang_tool_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,11 @@ class DebounceLangToolService extends LanguageCheckService {

return value ?? [];
}

@override
Future<void> dispose() async {
await debouncing.close();

return baseService.dispose();
mitryp marked this conversation as resolved.
Show resolved Hide resolved
}
}
7 changes: 7 additions & 0 deletions lib/implementations/throttling_lang_tool_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,11 @@ class ThrottlingLangToolService extends LanguageCheckService {
Future<List<Mistake>> findMistakes(String text) =>
throttling.throttle(() => baseService.findMistakes(text))
as Future<List<Mistake>>;

@override
Future<void> dispose() async {
await throttling.close();

return baseService.dispose();
}
}