Intelligent highlight #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
there is wrong behavior of highlight after replacing mistake. I'm currently fixing this bug |
solid-yuriiprykhodko
requested changes
May 24, 2023
solid-yuriiprykhodko
requested changes
May 24, 2023
|
Now it works fine in most cases, but sometimes there is hard-reproducible bug occurred. |
solid-yuriiprykhodko
requested changes
May 24, 2023
Comment on lines
+75
to
+82
| _mistakes.removeWhere((mistake) { | ||
| final mistakeRange = IntRange( | ||
| mistake.offset, | ||
| mistake.endOffset, | ||
| ).toSet(); | ||
|
|
||
| return selectionRange.intersection(mistakeRange).isNotEmpty; | ||
| }); |
There was a problem hiding this comment.
Replace with a well-named method:
Suggested change
| _mistakes.removeWhere((mistake) { | |
| final mistakeRange = IntRange( | |
| mistake.offset, | |
| mistake.endOffset, | |
| ).toSet(); | |
| return selectionRange.intersection(mistakeRange).isNotEmpty; | |
| }); | |
| _mistakes.removeWhere(_doesMistakeIntersectWithSelection); |
Set<int> get _selectionRange => IntRange(selection.start, selection.end).toSet();
bool _doesMistakeIntersectWithSelection(mistake) {
final mistakeRange = IntRange(
mistake.offset,
mistake.endOffset,
).toSet();
return _selectionRange.intersection(mistakeRange).isNotEmpty;
}There was a problem hiding this comment.
Also -- comparing start-end will be more efficient. We don't need the full set intersection here, do we?
All we need is to check whether two integers (mistake start-end) are inclusively within the selection range.
solid-yuriiprykhodko
requested changes
May 24, 2023
| @@ -69,14 +70,43 @@ class ColoredTextEditingController extends TextEditingController { | |||
| ///so this check avoid cleaning Mistake list when text wasn't really changed | |||
| if (newText == text) return; | |||
|
|
|||
| _mistakes.clear(); | |||
| for (final recognizer in _recognizers) { | |||
| recognizer.dispose(); | |||
There was a problem hiding this comment.
Memory leak introduced?
Perhaps we need an extra internal structure to map mistakes to their respective tap recognizers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not update unchanged text errors and move highlighting with text expansion