Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mistake Popup #29

Merged
merged 19 commits into from
May 24, 2023
Merged

Mistake Popup #29

merged 19 commits into from
May 24, 2023

Conversation

drooxie
Copy link
Contributor

@drooxie drooxie commented May 23, 2023

No description provided.

@drooxie drooxie self-assigned this May 23, 2023
solid-yuriiprykhodko
solid-yuriiprykhodko requested changes May 23, 2023
View reviewed changes
lib/utils/mistake_popup.dart Outdated Show resolved Hide resolved
lib/utils/mistake_popup.dart Outdated Show resolved Hide resolved
lib/utils/mistake_popup.dart Outdated Show resolved Hide resolved
lib/utils/mistake_popup.dart Outdated Show resolved Hide resolved
lib/utils/mistake_popup.dart Outdated Show resolved Hide resolved
lib/utils/mistake_popup.dart Outdated Show resolved Hide resolved
lib/utils/mistake_popup.dart Outdated Show resolved Hide resolved
lib/core/controllers/colored_text_editing_controller.dart Outdated Show resolved Hide resolved
lib/core/controllers/colored_text_editing_controller.dart Outdated Show resolved Hide resolved
lib/core/controllers/colored_text_editing_controller.dart Outdated Show resolved Hide resolved
solid-yuriiprykhodko
solid-yuriiprykhodko requested changes May 23, 2023
View reviewed changes
lib/utils/mistake_popup.dart Outdated Show resolved Hide resolved
lib/utils/mistake_popup.dart Outdated Show resolved Hide resolved
@drooxie
Copy link
Contributor Author

drooxie commented May 23, 2023 •
edited
Loading

issues

are still relevant

drooxie
drooxie commented May 23, 2023
View reviewed changes
Copy link
Contributor Author

@drooxie drooxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All suggested changes were implemented

solid-yuriiprykhodko
solid-yuriiprykhodko requested changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@solid-yuriiprykhodko solid-yuriiprykhodko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise, aside from a minor cleanup.
Please attach screenshots or a screen recording of the UI.

lib/utils/mistake_popup.dart Outdated Show resolved Hide resolved
analysis_options.yaml Outdated Show resolved Hide resolved
example/lib/app.dart Outdated Show resolved Hide resolved
lib/utils/mistake_popup.dart Outdated Show resolved Hide resolved
lib/utils/popup_overlay_renderer.dart Outdated Show resolved Hide resolved
solid-yuriiprykhodko
solid-yuriiprykhodko requested changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@solid-yuriiprykhodko solid-yuriiprykhodko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there!

example/lib/app.dart Outdated Show resolved Hide resolved
lib/utils/popup_overlay_renderer.dart Outdated Show resolved Hide resolved
lib/utils/popup_overlay_renderer.dart Outdated Show resolved Hide resolved
solid-yuriiprykhodko
solid-yuriiprykhodko approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@solid-yuriiprykhodko solid-yuriiprykhodko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drooxie drooxie merged commit d922d5a into main May 24, 2023
1 check passed
@drooxie drooxie deleted the feat/mistake-popup branch May 24, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solid-yuriiprykhodko solid-yuriiprykhodko solid-yuriiprykhodko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drooxie @solid-yuriiprykhodko