Created text editing controller which builds TextSpans from list of M… #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solid-yuriiprykhodko
requested changes
Apr 27, 2023
solid-yuriiprykhodko
requested changes
Apr 27, 2023
| /// Breaks the loop if iterated Mistake offset is bigger than text | ||
| /// length. | ||
| if (mistake.offset > textLength || | ||
| mistake.offset + mistake.length > textLength) { |
There was a problem hiding this comment.
mistake.offset + mistake.length
I see this used thrice in this method. DRY?
There was a problem hiding this comment.
Still seeing this line being repeated. Please review.
There was a problem hiding this comment.
I swear i got rid of it in recent commits
solid-yuriiprykhodko
requested changes
Apr 28, 2023
solid-yuriiprykhodko
requested changes
Apr 28, 2023
solid-yuriiprykhodko
approved these changes
Apr 28, 2023
Comment on lines
+34
to
+36
| ///set value triggers each time, even when cursor changes its location | ||
| ///so this check avoid cleaning Mistake list when text wasn't really changed | ||
| if (newText.length == text.length) return; |
There was a problem hiding this comment.
This is a really helpful comment here, good job!
There was a problem hiding this comment.
thanks, I really appreciate it!
Co-authored-by: Yuri Prykhodko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created text editing controller which builds text spans from MIstake list