Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nazarski setting up #18

Closed
wants to merge 3 commits into from
Closed

Nazarski setting up #18

wants to merge 3 commits into from

Conversation

nazarski
Copy link
Contributor

dart format fix

@solid-yuriiprykhodko solid-yuriiprykhodko changed the base branch from main to nazarski April 26, 2023 11:56
Copy link
Collaborator

@solid-yuriiprykhodko solid-yuriiprykhodko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits.

@@ -29,8 +31,24 @@ class LanguageToolTextField extends StatefulWidget {
}

class _LanguageToolTextFieldState extends State<LanguageToolTextField> {
// final TextEditingController _controller = TextEditingController();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not keep comments in VCS.

Suggested change
// final TextEditingController _controller = TextEditingController();
// final TextEditingController _controller = TextEditingController();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger roger

@solid-yuriiprykhodko
Copy link
Collaborator

@nazarski Is this obsolete now?

@nazarski nazarski closed this Apr 28, 2023
@solid-yuriiprykhodko solid-yuriiprykhodko deleted the nazarski_setting_up branch May 22, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants