Create initial design for TextField #15
Conversation
There was a problem hiding this comment.
Great job, @Luxorum. I've added a coupple of suggestions here - please, take a look.
There was a problem hiding this comment.
Almost there, @Luxorum! I've added a few more suggestions here - please, take a look an let me know what do you think.
lib/presentation/widgets/language_tool_text_editing_controller.dart
Outdated
Show resolved
Hide resolved
lib/presentation/widgets/language_tool_text_editing_controller.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Almost there, @Luxorum! I've added few more minor suggestions here - please, take a look.
lib/presentation/widgets/language_tool_text_editing_controller.dart
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| children.add( | ||
| TextSpan(text: text.substring(previousMistakePosition, mistakeStart)), |
There was a problem hiding this comment.
What if mistakeStart is our of range?
There was a problem hiding this comment.
There will be no errors anyways, cause if statement checks mistake.start + mistake.length
lib/presentation/widgets/language_tool_text_editing_controller.dart
Outdated
Show resolved
Hide resolved
| WidgetSpan( | ||
| child: Text( | ||
| mistakeCharacter, | ||
| style: style, |
There was a problem hiding this comment.
Why do we need it here? I think the TextSpan sets the proper TextStyle for all of its children.
There was a problem hiding this comment.
No, seems that Text overrides style by it's own
lib/presentation/widgets/language_tool_text_editing_controller.dart
Outdated
Show resolved
Hide resolved
lib/presentation/widgets/language_tool_text_editing_controller.dart
Outdated
Show resolved
Hide resolved
lib/presentation/widgets/language_tool_text_editing_controller.dart
Outdated
Show resolved
Hide resolved
No description provided.