Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document public members, where it is necessary #13

Merged
merged 5 commits into from
Apr 25, 2023
Merged

Document public members, where it is necessary #13

merged 5 commits into from
Apr 25, 2023

Conversation

Luxorum
Copy link
Contributor

@Luxorum Luxorum commented Apr 24, 2023

No description provided.

solid-vovabeloded
solid-vovabeloded requested changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@solid-vovabeloded solid-vovabeloded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, @Luxorum! I've added a couple of suggestions here - please, take a look.

lib/domain/language_check_service.dart Outdated Show resolved Hide resolved
lib/domain/mistake.dart Outdated Show resolved Hide resolved
lib/domain/mistake.dart Outdated Show resolved Hide resolved
lib/domain/mistake.dart Outdated Show resolved Hide resolved
lib/implementations/debounce_lang_tool_service.dart Outdated Show resolved Hide resolved
solid-vovabeloded
solid-vovabeloded requested changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@solid-vovabeloded solid-vovabeloded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, go through all of your code and apply previous suggestions.

lib/domain/language_check_service.dart Outdated Show resolved Hide resolved
lib/domain/mistake.dart Outdated Show resolved Hide resolved
lib/domain/mistake.dart Outdated Show resolved Hide resolved
solid-vovabeloded
solid-vovabeloded requested changes Apr 25, 2023
View reviewed changes
lib/domain/language_check_service.dart Outdated Show resolved Hide resolved
lib/domain/mistake.dart Outdated Show resolved Hide resolved
lib/domain/mistake.dart Outdated Show resolved Hide resolved
lib/implementations/debounce_lang_tool_service.dart Outdated Show resolved Hide resolved
lib/implementations/debounce_lang_tool_service.dart Outdated Show resolved Hide resolved
lib/presentation/language_tool_text_field.dart Outdated Show resolved Hide resolved
lib/presentation/language_tool_text_field.dart Outdated Show resolved Hide resolved
lib/presentation/language_tool_text_field.dart Outdated Show resolved Hide resolved
lib/presentation/language_tool_text_field.dart Outdated Show resolved Hide resolved
lib/presentation/language_tool_text_field.dart Outdated Show resolved Hide resolved
solid-vovabeloded
solid-vovabeloded approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@solid-vovabeloded solid-vovabeloded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Luxorum!

@Luxorum Luxorum merged commit 5ca884f into main Apr 25, 2023
1 check passed
@Luxorum Luxorum deleted the feat/document-public-members branch April 25, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solid-vovabeloded solid-vovabeloded solid-vovabeloded approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Luxorum @solid-vovabeloded