Merge pull request #133 from appoptics/AO-14725-better-logs

AO-14725: Logs improving
solarwinds · Dec 4, 2019 · 33e4b5a · 33e4b5a
2 parents d6a95ef + 076bc66
commit 33e4b5a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/v1/ao/internal/reporter/methods.go b/v1/ao/internal/reporter/methods.go
@@ -124,7 +124,7 @@ func (pe *PostEventsMethod) Call(ctx context.Context,
 // It is mainly used for debug printing.
 func (pe *PostEventsMethod) CallSummary() string {
 	rsp := resultRespStr(pe.Resp, pe.err)
-	return fmt.Sprintf("[%s] sent %d events, %d bytes, rtt=%v, rsp=%s.",
+	return fmt.Sprintf("[%s] sent %d events, %d bytes, rtt=%v, rsp=%s",
 		pe, pe.MessageLen(), pe.RequestSize(), pe.rtt, rsp)
 }
 
@@ -208,7 +208,7 @@ func (pm *PostMetricsMethod) Call(ctx context.Context,
 // mainly used for debug printing.
 func (pm *PostMetricsMethod) CallSummary() string {
 	rsp := resultRespStr(pm.Resp, pm.err)
-	return fmt.Sprintf("[%s] sent %d metrics, %d bytes, rtt=%v, rsp=%s.",
+	return fmt.Sprintf("[%s] sent %d metrics, %d bytes, rtt=%v, rsp=%s",
 		pm, pm.MessageLen(), pm.RequestSize(), pm.rtt, rsp)
 }
 
@@ -300,7 +300,7 @@ func (ps *PostStatusMethod) RetryOnErr(err error) bool {
 // mainly used for debug printing.
 func (ps *PostStatusMethod) CallSummary() string {
 	rsp := resultRespStr(ps.Resp, ps.err)
-	return fmt.Sprintf("[%s] sent status, rtt=%v, rsp=%s.", ps, ps.rtt, rsp)
+	return fmt.Sprintf("[%s] sent status, rtt=%v, rsp=%s", ps, ps.rtt, rsp)
 }
 
 // GetSettingsMethod is the struct for RPC method GetSettings
@@ -365,7 +365,7 @@ func (gs *GetSettingsMethod) Call(ctx context.Context,
 // CallSummary returns a string representation of the RPC call result.
 func (gs *GetSettingsMethod) CallSummary() string {
 	rsp := settingsRespStr(gs.Resp, gs.err)
-	return fmt.Sprintf("[%s] got settings, rtt=%v, rsp=%s.", gs, gs.rtt, rsp)
+	return fmt.Sprintf("[%s] got settings, rtt=%v, rsp=%s", gs, gs.rtt, rsp)
 }
 
 // RetryOnErr denotes if this method needs a retry on failure.
@@ -436,7 +436,7 @@ func (p *PingMethod) Call(ctx context.Context,
 // mainly used for debug printing.
 func (p *PingMethod) CallSummary() string {
 	rsp := resultRespStr(p.Resp, p.err)
-	return fmt.Sprintf("[%s] ping back, rtt=%v, rsp=%s.", p, p.rtt, rsp)
+	return fmt.Sprintf("[%s] ping back, rtt=%v, rsp=%s", p, p.rtt, rsp)
 }
 
 // RetryOnErr denotes if this RPC method needs a retry on failure.

diff --git a/v1/ao/internal/reporter/reporter_grpc.go b/v1/ao/internal/reporter/reporter_grpc.go
@@ -336,8 +336,8 @@ func newGRPCReporter() reporter {
 
 	r.start()
 
-	log.Warningf("AppOptics APM reporter v%s is initialized. id: %v Go version: %s.",
-		utils.Version(), r.done, utils.GoVersion())
+	log.Warningf("The reporter (%v, v%v, go%v) is initialized. Waiting for the dynamic settings.",
+		r.done, utils.Version(), utils.GoVersion())
 	return r
 }
 
@@ -921,7 +921,7 @@ func (r *grpcReporter) updateSettings(settings *collector.SettingsResult) {
 	if !r.isReady() && hasDefaultSetting() {
 		r.cond.L.Lock()
 		r.setReady(true)
-		log.Warningf("AppOptics agent (%v) is ready.", r.done)
+		log.Warningf("Got dynamic settings. The AppOptics APM agent (%v) is ready.", r.done)
 		r.cond.Broadcast()
 		r.cond.L.Unlock()
 	}

diff --git a/v1/ao/internal/utils/version.go b/v1/ao/internal/utils/version.go
@@ -7,7 +7,7 @@ import (
 
 var (
 	// The AppOptics Go agent version
-	version = "1.11.0"
+	version = "1.12.0"
 
 	// The Go version
 	goVersion = strings.TrimPrefix(runtime.Version(), "go")