Upgrades nightly Rust to 2023-03-04 #31487
Conversation
|
@yihau Can I get your help here to update the CI images? |
|
just retried the pipeline and it failed due to some lint issues 😢 |
Thanks! I'll fix these. |
| @@ -226,7 +226,7 @@ pub(crate) type Ping = ping_pong::Ping<[u8; REPAIR_PING_TOKEN_SIZE]>; | |||
|
|
|||
| /// Window protocol messages | |||
| #[derive(Debug, AbiEnumVisitor, AbiExample, Deserialize, Serialize)] | |||
| #[frozen_abi(digest = "3bgE3sYHRqetvpo4fcDL6PTV3z2LMAtY6H8BoLFSjCwf")] | |||
| #[frozen_abi(digest = "6VyBwHjkAMXAN97fdhQgFv6VdPEnfJo9LdUAd2SFtwF3")] | |||
There was a problem hiding this comment.
Rust moved some types from std to core in this PR: rust-lang/rust#104265, which causes the frozen abi code to see a bunch of diffs like this:
- field gossip: std::net::socket_addr::SocketAddr
+ field gossip: core::net::socket_addr::SocketAddrThis is safe, but does require updating the digest here.
For more info refer to Ryo's full writeup here: https://github.com/solana-labs/solana/pull/31381/files#r1184956432
| @@ -273,7 +273,7 @@ pub fn make_accounts_hashes_message( | |||
| pub(crate) type Ping = ping_pong::Ping<[u8; GOSSIP_PING_TOKEN_SIZE]>; | |||
|
|
|||
| // TODO These messages should go through the gpu pipeline for spam filtering | |||
| #[frozen_abi(digest = "FsZnSeTYNH7F51AxTaKUixXxjT6if2ThmPN1mhDWtXZM")] | |||
| #[frozen_abi(digest = "Ctxue3UVFXXqnHoMVAPmfBoCy3Cyg7gNCYBY7Cg9P3so")] | |||
There was a problem hiding this comment.
Same thing here too (as https://github.com/solana-labs/solana/pull/31487/files#r1185414718)
Codecov Report
@@ Coverage Diff @@
## master #31487 +/- ##
=========================================
- Coverage 81.4% 81.4% -0.1%
=========================================
Files 731 731
Lines 208718 205067 -3651
=========================================
- Hits 170017 166930 -3087
+ Misses 38701 38137 -564 |
|
@ryoqun Hopefully this PR to get the nightly version equivalent to the stable version will make your PR a bit simpler! |
Problem
The repo's nightly Rust version is old. In fact, it's older than the repo's stable Rust version 😬. Since we run clippy with nightly, we should strive to keep the nightly version current.
Summary of Changes
Upgrade nightly Rust to 2023-03-04, which is the latest nightly on version 1.69.0. Since this is the same version as our stable, we shouldn't run into any Rust-related issues 🤞