Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added /tx/inspector route to return transaction data #421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YaTut1901
Copy link

No description provided.

Copy link

vercel bot commented Nov 26, 2024

@YaTut1901 is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@ngundotra
Copy link
Collaborator

Hey Ivan, thanks for putting this together.

Some questions

  1. It looks like the InspectorPage never actually uses the api route. Can you update this to use the api route you added?

  2. Can you provide a few tests that assert api responses for different protocols on both mainnet & devnet?

@YaTut1901
Copy link
Author

@ngundotra you mean make InspectorPage to use api that I created to fetch data and display?

@YaTut1901
Copy link
Author

@ngundotra could you please clarify?

@ngundotra
Copy link
Collaborator

Yes can you please make the InspectorPage use the API route & add some tests?

@YaTut1901
Copy link
Author

@ngundotra it is quite a big task to refactor all that code in InspectorPage to use fetching from API. I would say this project is better to be migrated to monorepo structure to have API version and UI. But if to talk about refactoring just InspectorPage, may we finish this task with just making test for API and open another to refactor the UI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants