Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating release draft status from true to false #316

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

galargh
Copy link

@galargh galargh commented Feb 1, 2023

Hi! Thanks for creating this action 😊

One issue I've encountered is that it's currently impossible to use the action to publish a draft issue.

In this PR, I'm trying to address this issue by changing how existingRelease is being looked for from agetReleaseByTag call to iterating through allReleases. Previously, we were only iterating through allReleases if the desired state of the release was draft.

I'd suggest reviewing with whitespace changes hidden: https://github.com/softprops/action-gh-release/pull/316/files?diff=split&w=1

Testing

@chenrui333 chenrui333 added the bug Something isn't working label Jun 19, 2024
@chenrui333
Copy link
Collaborator

@galargh can you fix the merge conflicts? Thanks!

@galargh
Copy link
Author

galargh commented Jul 17, 2024

Of course! Done :) The diff is much cleaner now.

One possible optimisation for some use cases could be to:

  1. Try retrieving the release by tag
  2. If 1. fails, iterate through all the releases

Let me know if you want me to add that.

Copy link
Collaborator

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, can you add some tests as well?

@chenrui333
Copy link
Collaborator

chenrui333 commented Jul 19, 2024

also can you post some examples of how this PR (by pointing to the latest commit of this PR) being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants