Support Privacy Manifest: bump Starscream package version to upToNextMajor 4.0.8 #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nuclearace Please accept PR |
|
Would be amazing if you guys could merge this PR |
|
Any news about this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the impossibility of publishing iOS applications due to the Privacy Manifest rule which is now mandatory.
The problem is that socket.io is pointing to 4.0.6 Starscream, but Starscream started supporting the Privacy Manifest policy from 4.0.8.
This PR updates its minimum version from 4.0.6 to
4.0.8.I already published my application to the App Store with this change without any issues.
⭐️ Eventually, instead of using
upToNextMajoryou can useexact. It's up to you.