Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More new lamps #402

Closed
wants to merge 60 commits into from
Closed

More new lamps #402

wants to merge 60 commits into from

Conversation

Allonck
Copy link
Collaborator

@Allonck Allonck commented May 10, 2024

No description provided.

simontorres and others added 30 commits June 4, 2021 18:49
@simontorres
Added colored logs
7bdd209
@simontorres
Added more logging messages
d781506
@simontorres
Modified cross correlation function to allow center-bias results. For…
a9bb70b 
… instance when two spectra of the same lamp are compared, only a small shift between them is expected.
@simontorres
Fixed bug where the DCLOG1 keyword contained the wrong lamp name used.
8a2d65f
@simontorres
Increase radeg and decdeg precision to 6 decimal numbers. closes s…
49990ee 
…oar-telescope#357
@simontorres
Renamed astropy's model BlackBody1D to BlackBody to be updated with p…
2220fd1 
…arent library
@simontorres
Removed NoMatchFound exception in get_reference_lamp
a9ce824
@simontorres
Created Interactive Extraction class
0cff6a3
@simontorres
wrapped show maximized in try/except statement
eabe200
@simontorres
Added create reference lamp method
d47aa91
@simontorres
fixed core tests for removal of NoMatchFound exception
11c9031
@simontorres
fixed text to consider new error message
d0f4436
@simontorres
added GSP's wcs keywords to lamps
1cfc016
@simontorres
Added better debug message for when a lamp is found or not
9d179df
@simontorres
set mask to None for extracted targets and modified tests accordingly
80e0cc6
@simontorres
changed exception from NotImplemented to NotImplementedError
5cbc644
@simontorres
renamed interpolate method in core to interpolate_spectrum to avoid c…
e2e3561 
…ollision with scipy's interpolate
@simontorres
Removed import scipy in favor of from scipy import signal, interpolate
2c3a3f5
@simontorres
set version to 1.3.5
4d26a72
@simontorres
updated change history and set release date
cb3e384
@SunilSimha @simontorres
process imaging data taken with FILTER2
52ccee5
@simontorres
Replaced HgArNe lamps for 600Mid GG395 (new filter, old was GG385) an…
6692357 
…d 400M1
@simontorres
Changed version to 1.3.6
b590f75
@simontorres
Fixed deprecation warning
37f1e6c
@simontorres
Updated Change History
6a740c2
@simontorres
Fixed big size of files
0f920a6
@simontorres
corrected exception
0f692e1
@simontorres
small docs updates
98b25bd
@simontorres
adding a resample option to save_science_data
6f704b3
@griffin-h @simontorres
pipe through --ignore-bias to create_master_flats
dd1c173
simontorres and others added 28 commits March 21, 2024 18:44
@simontorres
Changed middle click to right click event to save point, also added p
6418dbe
@simontorres
Brought back interactive wavelength calibration call
7a7f9f1
@simontorres
Add new save method with linearizing as an option
2fd31ee
@simontorres
rename add_wavelength_solution to add_linear_wavelength solution
3b782a8
@simontorres
improve help texts and added keystroke commmand. p to add new point
e68c533
@simontorres
Renamed redspec class from MainApp to RedSpec
d9b575f
@simontorres
rename MainApp to RedCCD and RedSpec respectively
c3f1d65
@simontorres
rename function add_wcs_keys to add_linear_wcs_keys
7c783d9
@simontorres
remove premature addition of linear wcs keys to file headers
cffbafe
@simontorres
Create single function to record wavelength solution evaluation
aae3d94
@simontorres
implementation of function to record wavelength solution evaluations
a87561c
@simontorres
using a single function to record linear wavelength solution
e442f32
@simontorres
apply flake8 corrections
4044c9b
@simontorres
Add GSP_LINE keyword for linearized data, add typing to WavelenthCali…
8dfd1dd 
…bration.__init__ method, add --linearize argument
@simontorres
update instance name
714cef9
@simontorres
Remove out of scope file
6396cb9
@simontorres
rename attribute calibration_lampt to more explicit comparison_lamp_f…
ef7c50c 
…ile_name
@simontorres
re implement interactive wavelength calibration, removed duplicated c…
5443816 
…ode.
@simontorres
changed typing for path
71f952e
@simontorres
change of supported python versions
990b913
@simontorres
remove wrong import
f389eec
@simontorres
comment unused code
e4a2d8e
@simontorres
add missing requirement
1abfe28
@simontorres
add missing requirement
b5b3968
@Allonck
Merge branch 'main' of github.com:soar-telescope/goodman_pipeline int…
e78122c 
…o interactive_v2
@Allonck
Merge remote-tracking branch 'simon/improve_cross_correlation' into i…
6d4e6a6 
…nteractive_v2
@Allonck
Add 2100_3900A lamp
447231d
@Allonck
Add 2100_650nm lamp
4726b5a
@Allonck Allonck closed this May 10, 2024
@Allonck Allonck deleted the more_new_lamps branch May 27, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Allonck @simontorres @SunilSimha @griffin-h