Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Update pr aa1 to master (Update PULL_REQUEST_TEMPLATE) #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update pr aa1 to master (Update PULL_REQUEST_TEMPLATE) #20

wants to merge 1 commit into from

Conversation

pinterid
Copy link
Member

@pinterid pinterid commented Aug 4, 2020

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

  • Currently the PR template does not pass Codacy.

What is the new behavior (if this is a feature change)?

  • Now the PR template passes Codacy.

Other information:

  • Ref: 🐍

@pinterid
Update PULL_REQUEST_TEMPLATE
0fa8a5d 
Improve Code Quality.
@pinterid pinterid added the documentation Improvements or additions to documentation label Aug 4, 2020
@pinterid pinterid self-assigned this Aug 4, 2020
Aichnerc
Aichnerc approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@Aichnerc Aichnerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kleberbaum
kleberbaum approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kleberbaum kleberbaum kleberbaum approved these changes

@Aichnerc Aichnerc Aichnerc approved these changes

@schettn schettn Awaiting requested review from schettn

Assignees

@pinterid pinterid

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pinterid @Aichnerc @kleberbaum