Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pr aa1 to master (Update PULL_REQUEST_TEMPLATE) #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update pr aa1 to master (Update PULL_REQUEST_TEMPLATE) #113

wants to merge 1 commit into from

Conversation

pinterid
Copy link
Member

@pinterid pinterid commented Aug 5, 2020

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

  • Currently the PR template does not pass Codacy.

What is the new behavior (if this is a feature change)?

  • Now the PR template passes Codacy.

Other information:

  • Ref: 🐍

@pinterid
Update PULL_REQUEST_TEMPLATE
d47279e 
Improve code quality.
@pinterid pinterid added the documentation Improvements or additions to documentation label Aug 5, 2020
@pinterid pinterid self-assigned this Aug 5, 2020
Aichnerc
Aichnerc approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@Aichnerc Aichnerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

schettn
schettn approved these changes Aug 8, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schettn schettn schettn approved these changes

@Aichnerc Aichnerc Aichnerc approved these changes

@kleberbaum kleberbaum Awaiting requested review from kleberbaum

Assignees

@pinterid pinterid

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pinterid @Aichnerc @schettn