fix(rt): second fix for okhttp engine crashing on Android when coroutine is cancelled uploading request body #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine is cancelled uploading request body
|
Kudos, SonarCloud Quality Gate passed!
|
lauzadis
approved these changes
Nov 3, 2022
lucix-aws
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
awslabs/aws-sdk-kotlin#733
Description of changes
The previous fix applied in #723 was not insufficient. This change wraps the entire
writeTomethod in atry/catchblock and surfaces everything asIOExceptionfrom there. This change was tested locally by Amplify to verify the behavior.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.