Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usi downloader #755

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Alexander-Sol
Copy link
Contributor

Implemented UsiLoader class that downloads spectra from various databases as JSON, then converts them into a lightweight UsiSpectrumFromJSON class. Conversion from JSON object is done using Newtonsoft, which is a nuget package that this PR adds to the UsefulProteomicsDatabases dependencies.

MzSpectrum objects can be extracted from UsiSpectrumFromJSON objects.

UsiSpectrumFromJSON spectra could have many possible attributes, of which and isolation window and peptide base sequence can currently be accessed.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: Patch coverage is 40.86022% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 74.79%. Comparing base (cf854ac) to head (7396dbe).

❗ Current head 7396dbe differs from pull request most recent head c4b6396. Consider uploading reports for the commit c4b6396 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
- Coverage   75.06%   74.79%   -0.28%     
==========================================
  Files         189      187       -2     
  Lines       30235    30165      -70     
  Branches     3035     3014      -21     
==========================================
- Hits        22697    22562     -135     
- Misses       7024     7083      +59     
- Partials      514      520       +6     
Files Coverage Δ
mzLib/UsefulProteomicsDatabases/UsiLoader.cs 65.51% <65.51%> (ø)
mzLib/Test/DatabaseTests/TestUsiDownload.cs 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants