Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Image 0.25 #7365

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Update to Image 0.25 #7365

merged 2 commits into from
Jan 14, 2025

Conversation

ogoffart
Copy link
Member

Added image-default-formats with all the format supported by image by default, and enable that feature by default.
Also put that feature in compat-1-2 for compatibility with user that have used image 0.24 with enabled features.
Make a new compat-1-10 feature that does not enable default format by default

ChangeLog: upgraded image crate to 0.25, added a new cargo feature to enable all image formats. (that feature is enabled by default with compat-1-2, added compat-1-10 to disable it

Fixes #7251

@ogoffart ogoffart requested a review from tronical January 14, 2025 14:00
@ogoffart
Copy link
Member Author

Contrary to what issue #7251 is saying, this doesn't add a feature per image. Just a single feature to enable al the default one.
I don't think users need to selectively enable such features anyway. It's either all or just png/jpeg.

api/rs/slint/Cargo.toml Outdated Show resolved Hide resolved
internal/interpreter/Cargo.toml Outdated Show resolved Hide resolved
Added image-default-formats with all the format supported by image by
default, and enable that feature by default.
Also put that feature in compat-1-2 for compatibility with user that
have used image 0.24 with enabled features.
Make a new compat-1-10 feature that does not enable default format by
default

ChangeLog: upgraded image crate to 0.25, added a new cargo feature
to enable all image formats. (that feature is enabled by default with
compat-1-2, added compat-1-10 to disable it

Fixes #7251
@ogoffart ogoffart merged commit 8a5df27 into master Jan 14, 2025
37 checks passed
@ogoffart ogoffart deleted the olivier/image branch January 14, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to image 0.25 and add feature flags for format selection
2 participants