Make the printerdemo and printerdemo_mcu PrinterQueueItem compatible with each other #7190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a string instead of the JobStatus enum. This makes the PrinterQueue code compatible with the printerdemo code, allowing us to switch between mcu and non-mcu versions of this demo, depending on what will fit on a device. A string is used, rather than porting the non-mcu demo to an enum, because the non-mcu demo needs to work with the cpp_interpreted demo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
printerdemo_mcu PrinterQueueItem uses a status string instead of the JobStatus enum.
This makes the PrinterQueue code compatible with the printerdemo code, allowing us to switch between mcu and non-mcu versions of this demo, depending on what will fit on a device.
A string is used, rather than porting the non-mcu demo to an enum, because the non-mcu demo needs to work with the cpp_interpreted demo. Currently, the interpreter does not have support for enumerations (#4777).