Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect binding loops when it involve the condition of a if in a layout #7132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Detect binding loops when it involve the condition of a if in a layout #7132

wants to merge 1 commit into from

Conversation

ogoffart
Copy link
Member

Fixes #7126

@ogoffart ogoffart requested a review from tronical December 17, 2024 10:56
@ogoffart
Copy link
Member Author

This is dangerous as I cannot be sure there is no false positive that would cause regression. So I don't think we should put that in 1.9 at this time.

@ogoffart ogoffart mentioned this pull request Dec 17, 2024
Open
tronical
tronical approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@tronical tronical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you put this change into 1.9.1 or rather 1.10?

I don't mind if you want to put this into 1.9 and we make a 1.9.1 if a follow-up is needed.

@tronical
Copy link
Member

(a crater run might give confidence?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tronical tronical tronical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditional element causes runtime panic when used as breakpoint
2 participants
@ogoffart @tronical