Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove draw_rect() shortcut in ItemRenderer trait #7106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove draw_rect() shortcut in ItemRenderer trait #7106

wants to merge 1 commit into from

Conversation

tronical
Copy link
Member

As discussed during API Review, reducing the API surface.

@tronical
Remove draw_rect() shortcut in ItemRenderer trait
2859eb1 
As discussed during API Review, reducing the API surface.
@tronical tronical requested a review from ogoffart December 16, 2024 08:53
@tronical
Copy link
Member Author

This is not very pretty though, and it doesn't cover the solid fill. I think that it may be time to bite the bullet, give WindowItem a hand-made draw() function that covers solid and brush, call that from the item renderer, then call the rendering notifier for underlay rendering, and then continue with regular item drawing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogoffart ogoffart Awaiting requested review from ogoffart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tronical