Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tree-sitter init for publish #7074

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrmoulton
Copy link
Contributor

I published a new version of this rust binding for the tree-sitter-slint crate. (I've also added @hunger as an owner). If you to include the tree-sitter generated bindings that are on by default with the tree-sitter init command this is the result.

These things can be regenerated for publishing later so including this isn't strictly necessary but I think this would be good to include.

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2024

CLA assistant check
All committers have signed the CLA.

@hunger
Copy link
Member

hunger commented Dec 12, 2024

The monorepo has the bare-bones of the tree-sitter support, so do we need these files here?

Neovim and helix both point to https://github.com/slint-ui/tree-sitter-slint, which is just our tree-sitter support without everything else: The neovim/helix devs hated having to pull down everything slint:-) Some more esoteric editors even rely on the tree-sitter code being in the top level of the repo.

In that repo we have all those files. I wonder whether we need to update those? Should that maybe become part of the github workflow to update that repo from the monorepo?

@hunger
Copy link
Member

hunger commented Dec 12, 2024

Thanks for making me co-owner of the crate by the way.

Do you think we can maybe automate publishing that crate based in the tree-sitter-slint repo so that the crate stays up to date with the editors?

@jrmoulton
Copy link
Contributor Author

ah whoops. I missed that there was a new repo. Yeah these aren't necessary here then.

Do you think we can maybe automate publishing that crate based in the tree-sitter-slint repo so that the crate stays up to date with the editors?

yeah should be possible although I'm honestly not sure when it needs updated and when it doesn't.

@hunger
Copy link
Member

hunger commented Dec 13, 2024

The grammar stayed in the monorepo and we sync over, so we can do nightly tests to see whether we broke the grammar. We do that sync "manually".

Syncing to the tree-sitter-slint repo we generate all the files with the latest (stable) tree-sitter and commit that. That's a no-op when nothing changed and creates a commit otherwise. That happens in an out of the way branch as neovim pulls from master and just ships that... so we only update master on releases:-)

So the "boring" update sequence just follows master and sees one push per release (if anything changed in the grammar in the release timeframe).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants