Don't depends inconditionally on critical-section for portable-atomic #6713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the compilation (link) of the esp-edf build for esp32s2 in the nightly test CI, as that platform doesn't have atomic, and also we don't provide an implementation of the critical-section function from the slint-cpp crate. Use the unsafe-single-threaded feature instead. CC #5057
tronical
added a commit
that referenced
this pull request
Nov 26, 2024
This configuration has been causing build issues for many weeks now and this isn't something we've ever seen in production. cc #6713
tronical
added a commit
that referenced
this pull request
Nov 26, 2024
This configuration has been causing build issues for many weeks now and this isn't something we've ever seen in production. cc #6713
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the compilation (link) of the esp-edf build for esp32s2 in the nightly test CI, as that platform doesn't have atomic, and also we don't provide an implementation of the critical-section function from the slint-cpp crate.
Use the unsafe-single-threaded feature instead.
CC #5057