Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to image 0.25 and add feature flags for format selection #7251

Open
3 tasks
tronical opened this issue Jan 2, 2025 · 3 comments · May be fixed by #7365
Open
3 tasks

Upgrade to image 0.25 and add feature flags for format selection #7251

tronical opened this issue Jan 2, 2025 · 3 comments · May be fixed by #7365
Labels
a:language-c++ C++ API, codegen, CMake build system (mS,mO) a:language-rust Rust API and codegen (mO,mS) api Changes or additions to APIs enhancement New feature or request
Milestone
1.10

Comments

@tronical
Copy link
Member

tronical commented Jan 2, 2025 •
edited
Loading

We should upgrade to image 0.25 and to replace the implicit public dependency via image format selection (see #7218).

  • We should have image-format-XXX features for supported formats.
  • We should have image-default-formats as per commit a159562.
  • For Node.js and Python we need to make sure that both have all default image formats selected.

Note: Double check that Zune-jpeg fix is available to us.
@tronical tronical added enhancement New feature or request a:language-c++ C++ API, codegen, CMake build system (mS,mO) a:language-rust Rust API and codegen (mO,mS) api Changes or additions to APIs labels Jan 2, 2025
@tronical tronical added this to the 1.10 milestone Jan 2, 2025
@ogoffart
Copy link
Member

ogoffart commented Jan 2, 2025

For context, we tried to upgrade before and this was reverted in 305e02e that lists the reasons

@ogoffart
Copy link
Member

ogoffart commented Jan 3, 2025

Naming-wise, should the default option be image-format-defaults or image-format-all
Should we offer an option to disable png and jpeg?
Should image-format-svg be added as well despite it is not handled by the image crate?

@tronical
Copy link
Member Author

tronical commented Jan 3, 2025

My take:

Naming-wise, should the default option be image-format-defaults or image-format-all

I'd go with image-default-formats. "default" over "all" as perhaps in the future image may add non-default formats, such as experimental ones.

Should we offer an option to disable png and jpeg?

Yes, true, we should offer to disable png/jpeg. I guess that can only be done if we make image-default-formats the default, so that one can opt out?

Should image-format-svg be added as well despite it is not handled by the image crate?

I'd say no.

What's your opinion?

ogoffart added a commit that referenced this issue Jan 14, 2025
@ogoffart
Update to Image 0.25
c6ee605 
Added image-default-formats with all the format supported by image by
default, and enable that feature by default.
Also put that feature in compat-1-2 for compatibility with user that
have used image 0.24 with enabled features.
Make a new compat-1-10 feature that does not enable default format by
default

ChangeLog: upgraded image crate to 0.25, added a new cargo feature
to enable all image formats. (that feature is enabled by default with
compat-1-2, added compat-1-10 to disable it

Fixes #7251
ogoffart added a commit that referenced this issue Jan 14, 2025
@ogoffart
Update to Image 0.25
19fbb59 
Added image-default-formats with all the format supported by image by
default, and enable that feature by default.
Also put that feature in compat-1-2 for compatibility with user that
have used image 0.24 with enabled features.
Make a new compat-1-10 feature that does not enable default format by
default

ChangeLog: upgraded image crate to 0.25, added a new cargo feature
to enable all image formats. (that feature is enabled by default with
compat-1-2, added compat-1-10 to disable it

Fixes #7251
@ogoffart ogoffart linked a pull request Jan 14, 2025 that will close this issue
Open
ogoffart added a commit that referenced this issue Jan 14, 2025
@ogoffart
Update to Image 0.25
37a68d2 
Added image-default-formats with all the format supported by image by
default, and enable that feature by default.
Also put that feature in compat-1-2 for compatibility with user that
have used image 0.24 with enabled features.
Make a new compat-1-10 feature that does not enable default format by
default

ChangeLog: upgraded image crate to 0.25, added a new cargo feature
to enable all image formats. (that feature is enabled by default with
compat-1-2, added compat-1-10 to disable it

Fixes #7251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:language-c++ C++ API, codegen, CMake build system (mS,mO) a:language-rust Rust API and codegen (mO,mS) api Changes or additions to APIs enhancement New feature or request
Projects
None yet
Milestone
1.10
Development

Successfully merging a pull request may close this issue.

Update to Image 0.25 slint-ui/slint
2 participants
@tronical @ogoffart