Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize deps errors in global installation mode #1559

Merged
merged 21 commits into from
May 2, 2024

Conversation

KermanX
Copy link
Member

@KermanX KermanX commented Apr 30, 2024

fix #1409, fix #1440, fix #1479, fix #1538, fix #1385.

Updated CI to upload built packed packages as artifacts, because I can't pack them on my machine, and this can save GitHub's money. And YARN is removed from CI because of some installation problem. As a vue-based project, I think only a very small percent of users will use yarn.

This is still a workaround. I tried for days to make Vite resolve properly when there are both alias and optimizeDeps, but failed, and I can't make a minimal reproduction of what's happening in Slidev's global mode for opening an issue in Vite.

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 3fe9188
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/66310422498a0a000730d0d9
😎 Deploy Preview https://deploy-preview-1559--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KermanX KermanX changed the title fix: errors in global mode caused by optimize deps fix: optimize deps errors in global installation mode Apr 30, 2024
@KermanX KermanX marked this pull request as ready for review April 30, 2024 13:48
packages/client/package.json Outdated Show resolved Hide resolved
@antfu antfu merged commit e03fd38 into slidevjs:main May 2, 2024
21 checks passed
@KermanX KermanX mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment