Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use <Link> component for internal links #1553

Merged
merged 6 commits into from May 2, 2024

Conversation

BanShan-Alec
Copy link
Contributor

@BanShan-Alec BanShan-Alec commented Apr 18, 2024

resolve #1551

Transform [foo](/1) into <Link to="/1">foo</Link>

edited by KermanX

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit ba7bfe5
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/6624a63cef04580008d6daa7
😎 Deploy Preview https://deploy-preview-1553--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BanShan-Alec
Copy link
Contributor Author

autofix.ci / autofix (pull_request) Failing 我好像看不出来failing的具体原因 @antfu

@KermanX KermanX changed the title feat: link-attrs support absolute path fix: only set anchor target to _blank for external links Apr 18, 2024
@KermanX KermanX marked this pull request as draft April 18, 2024 13:43
@KermanX KermanX changed the title fix: only set anchor target to _blank for external links feat: use <Link> component for internal links Apr 18, 2024
@KermanX KermanX marked this pull request as ready for review April 18, 2024 14:36
@antfu antfu merged commit f6507c1 into slidevjs:main May 2, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link Attributes,Please don't add tartget="_blank" always.
3 participants