Add --browser option to export #1196
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjl9903
reviewed
Dec 23, 2023
|
|
||
| const { chromium } = await import('playwright-chromium') | ||
| const browser = await chromium.launch() | ||
| const { playwright } = await import(browserPackage) |
There was a problem hiding this comment.
Does this works fine?
I think the following seems better. Make bundler more friendly knows which is imported here, instead of a dynamic string, even if you have checked before.
function loadBrowser(browserPackage) {
if (browserPackage == 'chromium') {
return import('playwright-chromium')
} else ...
}
|
I think that playwright support PDF generation only with the Chromium version [0] microsoft/playwright#2206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1195.
Not tested yet because I was not able to correctly build this package locally.