Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link Attributes，Please don't add tartget="_blank" always. #1551

Closed
BanShan-Alec opened this issue Apr 18, 2024 · 1 comment · Fixed by #1553
Closed

Link Attributes，Please don't add tartget="_blank" always. #1551

BanShan-Alec opened this issue Apr 18, 2024 · 1 comment · Fixed by #1553
Labels
enhancement New feature or request planned

Comments

@BanShan-Alec
Copy link
Contributor

I'd rather use [link](/4) to change page than use componet <Link to="4">link</Link>.

but origin markdown link , always open page in new browser tab. It bothers me a lot.

After reading source code, I find this code can be change to resolve my problem. markdown-it-link-attributes.

I hope author can accept this feature: href.startsWith("/") means absolute path, attr don't set to tartget="_blank".

image
@BanShan-Alec BanShan-Alec added the enhancement New feature or request label Apr 18, 2024
@BanShan-Alec
Copy link
Contributor Author

change viteconifg-slidev-markdown config，can't override link attrs target: "_blank" config. @KermanX
image
image

@BanShan-Alec BanShan-Alec mentioned this issue Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request planned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use <Link> component for internal links BanShan-Alec/slidev
2 participants
@BanShan-Alec @KermanX