Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable tests that are now stable #1617

Merged

Conversation

WilliamBergamin
Copy link
Contributor

Summary

#1023 disabled units that were found to be unstable in our CI pipeline, #1615 improved the stability of these tests, this PR aims to reenable these unit tests in our CI pipeline

Testing

Test in CI pipeline

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (4dfcbf5) to head (62ab538).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1617   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files         113      113           
  Lines       12661    12661           
=======================================
  Hits        10770    10770           
  Misses       1891     1891           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice!! It's always reassuring when the CI jobs are running and passing more of the test suite 🧪 ✨

@@ -26,7 +26,6 @@ jobs:
- "pypy3.10"
env:
CI_LARGE_SOCKET_MODE_PAYLOAD_TESTING_DISABLED: "1"
CI_UNSTABLE_TESTS_SKIP_ENABLED: "1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓 😌 🎉

@WilliamBergamin WilliamBergamin merged commit 6ca12d0 into slackapi:main Dec 17, 2024
13 checks passed
@WilliamBergamin WilliamBergamin deleted the investigate-flaky-tests branch December 17, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants