-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor button styling to contextual tokens #1675
Draft
jpzwarte
wants to merge
124
commits into
main
Choose a base branch
from
feature/button-refactor-styling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…folder of token test theme.
… default to correct token in SL base
…n-setup' into feature/button-refactor-styling
…n-setup' into feature/button-refactor-styling
Diaan
approved these changes
Dec 16, 2024
Background and Opacity Tokens Muted Background: Uses opacity tokens. Applied as hover colors for components with a transparent background in the idle state. Subtlest, Subtle, and Bold Backgrounds: Each has one default background color. Interactive states (idle, hover, active) are managed using: opacity.interactive.idle/hover/active background.interactive Default Background Colors: Defined in accent colors. New naming format avoids specifying state, e.g., color.background.accent.blue.subtlest. Token Definitions: Opacity Tokens: opacity.interactive.idle/hover/active tokens are defined in system.json. Color Tokens: color.opacity tokens are in light.json and dark.json. color.background.interactive tokens are also in light.json and dark.json. Mode-Specific Behavior: In dark mode, interactive tokens use white. In light mode, interactive tokens use black.
….background.accent.grey.subtlest.idle, which is not defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.