Update intermediate bucket related doc #4521
Merged
+41
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -505,4 +538,3 @@ The :code:`resources` field has the same spec as a normal SkyPilot job; see `her | |||
| These settings will not take effect if you have an existing controller (either | |||
| stopped or live). For them to take effect, tear down the existing controller | |||
| first, which requires all in-progress jobs to finish or be canceled. | |||
|
|
|||
There was a problem hiding this comment.
It is stripped by trim trailing whitespace of pre-commit. Can we keep it as it is, or do we prefer a new line at the end of the file? If so, I will update the pre-commit config.
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook
Fixing docs/source/examples/managed-jobs.rst
| ├── local-file-mounts/ | ||
| ├── tmp-files/ | ||
| └── workdir/ | ||
|
|
There was a problem hiding this comment.
Can we add a tip mentioning that multiple users can use the same intermediate bucket?
Co-authored-by: Romil Bhardwaj <[email protected]>
Co-authored-by: Romil Bhardwaj <[email protected]>
Co-authored-by: Romil Bhardwaj <[email protected]>
Co-authored-by: Romil Bhardwaj <[email protected]>
Co-authored-by: Romil Bhardwaj <[email protected]>
Co-authored-by: Romil Bhardwaj <[email protected]>
romilbhardwaj
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh