Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vast: initial static catalog #102

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kristopolous
Copy link

No description provided.

@concretevitamin
Copy link
Member

cc @cblmemo

@@ -0,0 +1,741 @@
InstanceType,AcceleratorName,AcceleratorCount,vCPUs,MemoryGiB,Price,Region,GpuInfo,SpotPrice
1x-RTX_4090-256,RTX 4090,1,256,23.98828125,0.27,"Vietnam, VN","{'Gpus': [{'Name': 'RTX 4090', 'Count': 1, 'MemoryInfo': {'SizeInMiB': 24564}}], 'TotalGpuMemoryInMiB': 24564}",0.27
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check the naming convention in sky show-gpus -a for the accelerator names, e.g. we use RTX4090 instead of RTX 4090 : )

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it looks like a bunch of these GPUs you don't want... that's fine.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ csvcut -c 8 catalog.txt | tr -d '"' | tr "'" '"' | grep '{' | jq '.Gpus[0].Name' | sort -u
"A10"
"A100"
"A40"
"A800"
"GTX1070"
"GTX1080"
"GTX1660"
"H100"
"H200"
"L4"
"L40"
"L40S"
"P100"
"RTX2060"
"RTX2070"
"RTX2080"
"RTX3060"
"RTX3070"
"RTX3080"
"RTX3090"
"RTX4060"
"RTX4070"
"RTX4080"
"RTX4090"
"RTX5000-Ada"
"RTX6000"
"RTX6000-Ada"
"RTX8000"
"RTXA2000"
"RTXA4000"
"RTXA4500"
"RTXA5000"
"RTXA6000"
"T4"
"TitanV"
"V100"
$

That's what we have now, as of 90da1a6

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kristopolous
Copy link
Author

hey happy monday, I think this is now as requested

@@ -0,0 +1,610 @@
InstanceType,AcceleratorName,AcceleratorCount,vCPUs,MemoryGiB,Price,Region,GpuInfo,SpotPrice
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit: could we make Price and SpotPrice close to each other? Currently, it is a bit hard to see.

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kristopolous! It looks mostly good to me just a minor nit.

@@ -0,0 +1,610 @@
InstanceType,AcceleratorName,AcceleratorCount,vCPUs,MemoryGiB,Price,Region,GpuInfo,SpotPrice
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we have recently moved to v6. Please move this folder to catalogs/v6/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright no problem. I'll get that out shortly.

@kristopolous
Copy link
Author

so i was trying to find v6 schema changes so cloned the recent repo and I did the following:

skypilot-catalog/catalogs$  for i in v5/*/*csv; 
do v6=${i/v5/v6}; 
diff <( head -2 $i) <( head -2 $v6); 
echo $i $v6; done;

basically looking at the header and the first offering. I saw no differences. I was looking at the code change and all I found was this: skypilot-org/skypilot@3466469

It looks like the vms.csv initial I committed, except for the column orders is compatible. Am I missing something?

@Michaelvll
Copy link
Collaborator

so i was trying to find v6 schema changes so cloned the recent repo and I did the following:

skypilot-catalog/catalogs$  for i in v5/*/*csv; 
do v6=${i/v5/v6}; 
diff <( head -2 $i) <( head -2 $v6); 
echo $i $v6; done;

basically looking at the header and the first offering. I saw no differences. I was looking at the code change and all I found was this: skypilot-org/skypilot@3466469

It looks like the vms.csv initial I committed, except for the column orders is compatible. Am I missing something?

Oh, you just need to move the file committed to be in the folder v6/ instead of staying in v5. No other changes needed.

@kristopolous
Copy link
Author

It looks like the vms.csv initial I committed, except for the column orders is compatible. Am I missing something?

Oh, you just need to move the file committed to be in the folder v6/ instead of staying in v5. No other changes needed.

Alright, now there's both a v5 and v6 ... unless you want the v5 to go away

@kristopolous
Copy link
Author

are we good on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants