Fix Spotless Build failure #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skydoves change list is long because i ran |
skydoves
approved these changes
May 16, 2024
There was a problem hiding this comment.
Looks good to me, thank you for your hard work @FreedomChuks! 🙌
cbeyls
reviewed
May 16, 2024
| sourceCompatibility = JavaVersion.VERSION_17 | ||
| targetCompatibility = JavaVersion.VERSION_17 | ||
| toolchain { | ||
| languageVersion.set(JavaLanguageVersion.of(17)) |
There was a problem hiding this comment.
This is a bad idea, it will force Gradle to use an old JDK to build the app, even if a newer one is available.
See https://jakewharton.com/gradle-toolchains-are-rarely-a-good-idea/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
🛠 Implementation details
Describe the implementation details for this Pull Request.
Addressed issue #15 this PR resolves the reported issue and improves codebase formatting.
✍️ Explain examples
Explain examples with code for this updates.
this
Preparing a pull request for review
Ensure your change is properly formatted by running:
$ ./gradlew spotlessApplyPlease correct any failures before requesting a review.