Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: add traceroute workflow #1661

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dvandra
Copy link
Contributor

@dvandra dvandra commented Feb 15, 2019

No description provided.

@dvandra
Copy link
Contributor Author

dvandra commented Feb 15, 2019

run skydive-cdd-overview-tests

@masco
Copy link
Member

masco commented Feb 20, 2019

You need to rebase and change the parameter names according to the new yaml tags

@dvandra dvandra force-pushed the workflows_traceroute branch from 2162ab2 to 8112cbe Compare February 20, 2019 11:07
statics/workflows/traceroute.yaml Outdated Show resolved Hide resolved
statics/workflows/traceroute.yaml Outdated Show resolved Hide resolved
statics/workflows/traceroute.yaml Show resolved Hide resolved
@dvandra dvandra force-pushed the workflows_traceroute branch from 8112cbe to fec0202 Compare February 21, 2019 08:27
@masco
Copy link
Member

masco commented Feb 26, 2019

I propose to have two inner functions called getIP and getMAC . it will make the code more readable and simple.

@dvandra dvandra force-pushed the workflows_traceroute branch from fec0202 to 0e3448b Compare February 27, 2019 19:13
@lebauce
Copy link
Member

lebauce commented Mar 22, 2019

@dvandra It would be super nice to add a test for it as the ones in tests/workflow_test.go as our workflow mechanism is still pretty new, changes to it may break your workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants