-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow: add traceroute workflow #1661
Open
dvandra
wants to merge
1
commit into
skydive-project:master
Choose a base branch
from
dvandra:workflows_traceroute
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run skydive-cdd-overview-tests |
dvandra
force-pushed
the
workflows_traceroute
branch
from
February 15, 2019 20:21
1ffd441
to
2162ab2
Compare
You need to rebase and change the parameter names according to the new yaml tags |
masco
reviewed
Feb 20, 2019
dvandra
force-pushed
the
workflows_traceroute
branch
from
February 20, 2019 11:07
2162ab2
to
8112cbe
Compare
nplanel
reviewed
Feb 20, 2019
dvandra
force-pushed
the
workflows_traceroute
branch
from
February 21, 2019 08:27
8112cbe
to
fec0202
Compare
I propose to have two inner functions called |
dvandra
force-pushed
the
workflows_traceroute
branch
from
February 27, 2019 19:13
fec0202
to
0e3448b
Compare
@dvandra It would be super nice to add a test for it as the ones in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.