Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow nested list/tuple input/output and None type #200

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cijinsama
Copy link

Main change features:

  • Allow nested list/tuple input/output like
    def forward(self, x: torch.Tensor, y: List[Tuple[torch.Tensor, torch.Tensor, ...]]):
        ...
        return c, [(mean_1, var_1, weight_1), (mean_2, var_2, weight_2), ...]
  • Allow input/output with None in list/tuple

@cijinsama cijinsama closed this Jan 28, 2024
@cijinsama cijinsama reopened this Jan 28, 2024
Copy link

@willyfh willyfh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few comments in the file changes. In addition, is it appropriate to use a public function instead of the private one? (Using _ in front of the function name)

torchsummary/torchsummary.py Outdated Show resolved Hide resolved
torchsummary/torchsummary.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants