Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gemspec - update eventmachine, rack, sinatra, sqlite3 #546

Closed
wants to merge 1 commit into from

Conversation

MSP-Greg
Copy link

I am not familiar with mailcatcher. In another repo, someone opened an issue about installing on Windows, and I took a look at the gemspec.

Some of the dependencies are locked to old versions, and with EventMachine, that's an issue.

So, I updated a few items, and ran CI. It passed in my fork, so I'll assume it passes here. EventMachine may have some issues with OpenSSL 3, not sure about thin.

Also, re Windows, the current EventMachine release includes a Windows pre-compiled gem, but its gemspec does not have a required_ruby_version properly set with an upper bound. It only includes extension files for Ruby 2.0 thru 2.3. It's also rather old...

@MSP-Greg MSP-Greg changed the title gemspec - eventmachine, rack, sinatra, sqlite3 gemspec - update eventmachine, rack, sinatra, sqlite3 Jul 12, 2023
@sj26
Copy link
Owner

sj26 commented Jul 29, 2023

Ah yes, the old gems problem.

I locked down the versions of these gems because newer versions weren't running correctly. Especially skinny, the gem I wrote which used to power websockets. But I recently replaced skinny with a standard websocket gem, and then updated thin. There's a new version of mailcatcher, v0.9.0, out which I'm hoping will solve a bunch of issues by just updating thin. But eventmachine and friends are next on the block. (Ideally I'd like to remove and replace eventmachine, because it's a bit too old and fragile, probably with async.)

CI covers some things, but not all things. Mainly, do live updates via websockets still work?

@MSP-Greg
Copy link
Author

I locked down the versions of these gems

Understandable. I was mostly concerned about EM, as that's really old. But even the current version is old. One might consider it 'no longer maintained'. I have contributed to it, but I don't actively use it.

CI covers some things, but not all things

Good to know.

do live updates via websockets still work?

Haven't checked. I'll see if I can check that.

@sj26
Copy link
Owner

sj26 commented Jul 30, 2023

I tried a move conservative version, only upgrading eventmachine (1815bfe), and did some testing. Everything seems to be working. It is in a pre-release, v0.9.1.beta1 — please try it out:

gem install mailcatcher -v 0.9.1.beta1

@sj26
Copy link
Owner

sj26 commented May 17, 2024

I think the rest of these updates are covered by #554.

@sj26 sj26 closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants