Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom back-ends #92

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mayconbordin
Copy link

I've changed the server implementation in order to support custom back-ends. It reduces the amount of configuration for the server as well as simplifies the code as there's no need for checking which transport is to be used.

@sivy
Copy link
Owner

sivy commented Dec 16, 2014

I like the idea, however would like to see more tests exercising the new backend types, and confirm that no breakage is going to happen for current users.

@mayconbordin
Copy link
Author

I've included tests for the server and all the back-ends. I've also modified the ServerDaemon to start using the back-ends instead of giving all the options to the Server, the run_server arguments remain the same, with the only addition of the --delete-gauges argument.

The Server interface has changed only in the constructor, it's more simple now. But I'm assuming most people run the server as a daemon, in this case nothing has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants